K8SPG-1080 v3 module - #1686
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
egegunes
previously approved these changes
Jul 27, 2026
# Conflicts: # internal/controller/postgrescluster/instance_test.go # internal/controller/postgrescluster/pki.go
Contributor
Author
|
As discussed on the DS, making the PR draft so we could go back to it once we merged everything for the release. |
oksana-grishchenko
marked this pull request as draft
July 27, 2026 12:01
# Conflicts: # .github/workflows/reviewdog.yml # cmd/postgres-operator/main.go # internal/controller/pgupgrade/labels.go # internal/controller/pgupgrade/pgupgrade_controller.go # internal/controller/postgrescluster/cluster.go # internal/controller/postgrescluster/controller.go # internal/controller/postgrescluster/instance.go # internal/controller/postgrescluster/patroni.go # internal/controller/postgrescluster/pgadmin.go # internal/controller/postgrescluster/pgbackrest.go # internal/controller/postgrescluster/pgbackrest_test.go # internal/controller/postgrescluster/pgbouncer.go # internal/controller/postgrescluster/pgbouncer_test.go # internal/controller/postgrescluster/pki.go # internal/controller/postgrescluster/pki_test.go # internal/controller/postgrescluster/postgres.go # internal/patroni/config.go # internal/pgbackrest/config_test.go # internal/pgbouncer/config.go # internal/pgbouncer/reconcile.go # internal/pgbouncer/reconcile_test.go # internal/postgres/config.go # internal/postgres/config_test.go # percona/controller/pgbackup/controller.go # percona/controller/pgbackup/controller_test.go # percona/controller/pgcluster/controller.go # percona/controller/pgcluster/controller_test.go # percona/controller/pgcluster/owner_ref_migration.go # percona/controller/pgcluster/standby.go # percona/controller/pgcluster/standby_test.go # percona/naming/label.go # percona/watcher/wal.go # percona/watcher/wal_test.go
# Conflicts: # internal/controller/postgrescluster/pki_test.go # internal/controller/postgrescluster/postgres.go # internal/controller/postgrescluster/suite_test.go # percona/controller/utils.go
oksana-grishchenko
marked this pull request as ready for review
August 25, 2026 11:44
Collaborator
commit: 8eea1d8 |
Comment on lines
87
to
89
| if cr.Spec.Secrets.CustomRootCATLSSecret == nil { | ||
| secretsMeta = append(secretsMeta, metav1.ObjectMeta{Namespace: crunchyCluster.Namespace, Name: naming.RootCertSecret}) | ||
| secretsMeta = append(secretsMeta, naming.PostgresRootCASecret(crunchyCluster)) | ||
| } |
egegunes
approved these changes
Aug 27, 2026
mayankshah1607
approved these changes
Aug 27, 2026
gkech
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 module
Problem:
K8SPG-1080
PG 3.0.0 is released while go module still references v2 which makes it harder to use it.
Solution:
Implement v3 module
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability